London|26-ITP-January|Alexandru Pocovnicu|Sprint 1|Data Groups#959
Closed
alexandru-pocovnicu wants to merge 26 commits intoCodeYourFuture:mainfrom
Closed
London|26-ITP-January|Alexandru Pocovnicu|Sprint 1|Data Groups#959alexandru-pocovnicu wants to merge 26 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu wants to merge 26 commits intoCodeYourFuture:mainfrom
Conversation
…ove filtering of numeric values
… and add corresponding test cases
… negative numbers
…st negative number scenarios
…tests for non-number values
…ncluding empty arrays, negative numbers, decimals, and non-number values
… arrays with mixed types
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
Needs Review
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
changed the title
alexandru-pocovnicu
added
the
Needs Review
cjyuan
reviewed
Mar 17, 2026
cjyuan
added
Reviewed
Author
|
thank you |
alexandru-pocovnicu
added
Needs Review
cjyuan
reviewed
Mar 20, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+13
to
+14
| let filteredList = list.filter((x) => typeof x === "number"); | ||
| let sortedList = filteredList.sort((a, b) => a - b); |
Contributor
There was a problem hiding this comment.
These variables wont' be reassigned a new value. Best practice is to declare them with const.
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Applied TDD, wrote and read test suites, then implemented functions to pass those tests.